Remove sysvinit-tools as an RPM package dependency #6965
Conversation
|
This breaks non-systemd systems. The reason why this was added was for systems using sysvinit. |
|
@jsternberg Can you provide the error you see when installing on non-systemd systems? I believe we've always supported non-systemd systems, and I don't recall seeing any issues. If we want to include it as a dependency, then we'll need to maintain multiple versions of the packages: one for systemd, and one for sysvinit. |
| PID="$(cat $PIDFILE)" | ||
| if kill -0 "$PID" &>/dev/null; then | ||
| # Process is already up | ||
| log_success_msg "$NAME process is already running" |
There was a problem hiding this comment.
There's some really weird indentation here.
There was a problem hiding this comment.
All weird indentation should be fixed. Looks like my editor mixed in tabs and spaces for indentation.
|
Looks fine for the most part. There's a lot of weird indentation so double check for tabs/spaces and the proper indentation and otherwise I think this is good to go. |
|
Squash the commits and it LGTM on green. Have you tried installing it on both CentOS 6 and CentOS 7 to double check that it works? |
rossmcdonald
force-pushed
the
ross-package-fix
branch
2 times, most recently
from
7f34c17 to
ab71033
Compare
* Removes sysvinit-tools as an RPM package dependency. * Update init script to not rely on sysvinit utils for backwards compatibility. * Minor overall improvements to init script (improved error messages, comments, check for root privileges). * Adds SLES support to post-installation script.
rossmcdonald
force-pushed
the
ross-package-fix
branch
from
ab71033 to
c769639
Compare
|
@jsternberg Rebased, and tested on CentOS 5, 6, and 7, along with Ubuntu Trusty, Wily, and Xenial without issue. |
Required for all non-trivial PRs
This PR reverts #6835, which added sysvinit-tools as an RPM dependency.
/cc @jsternberg